On Wed, Jul 27, 2016 at 12:31 AM, zhuyj <zyjzyj2...@gmail.com> wrote: > + if (vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { > <-----Does this happen very rarely? If so, > > if (unlikely(vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { is > better?
This is not in the fast path, so it doesn't matter. > > + netdev_warn(bp->dev, > + "Not enough resources to support NTUPLE > filters, enough resources for up to %d rx rings\n", > + min(pf->max_rsscos_ctxs - 1, pf->max_vnics - 1)); > return false; > + } >