I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/net/irda/mcs7780.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda/mcs7780.c b/drivers/net/irda/mcs7780.c index bca6a1e..f43b521 100644 --- a/drivers/net/irda/mcs7780.c +++ b/drivers/net/irda/mcs7780.c @@ -89,12 +89,12 @@ MODULE_PARM_DESC(receive_mode, "Receive mode of the device (1:fast, 0:slow, default:1)"); static int sir_tweak = 1; -module_param(sir_tweak, int, 0444); +module_param(sir_tweak, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(sir_tweak, "Default pulse width (1:1.6us, 0:3/16 bit, default:1)."); static int transceiver_type = MCS_TSC_VISHAY; -module_param(transceiver_type, int, 0444); +module_param(transceiver_type, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(transceiver_type, "IR transceiver type, see mcs7780.h."); static struct usb_driver mcs_driver = { -- 2.9.2
