On Thu, Aug 25, 2016 at 10:48 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > > Please find a better way than using a spinlock in this hot path. > > Maybe looking at > 2ee22a90c7afac265bb6f7abea610b938195e2b8 net_sched: act_mirred: remove > spinlock in fast path > 56e5d1ca183d8616fab377d7d466c244b4dbb3b9 net_sched: act_gact: remove spinlock > in fast path
This is not necessary at the moment, because: 1) Currently there are only a few actions using lockless, and they are questionable, as we already discussed before, there could be some race condition when you modify an existing action. 2) We need to change the tc action API in order to fully support RCU, which is what I have been working on these days. I should come up with something next Monday (if not this weekend). So for this patchset, using spinlock is fine, just as many other actions. I will take care of it later.
