Hi,
Shouldn't it be obj-$(CONFIG_QCOM_EMAC) instead obj-y? QCOM_EMAC is defined as
tristate in the drivers/net/ethernet/qualcomm/Kconfig by this patch,
so it should be possible to build it as a *.ko module also.
> diff --git a/drivers/net/ethernet/qualcomm/emac/Makefile
> b/drivers/net/ethernet/qualcomm/emac/Makefile
> new file mode 100644
> index 0000000..700ee6e
> --- /dev/null
> +++ b/drivers/net/ethernet/qualcomm/emac/Makefile
> @@ -0,0 +1,7 @@
> +#
> +# Makefile for the Qualcomm Technologies, Inc. EMAC Gigabit Ethernet driver
> +#
> +
> +obj-y += qcom-emac.o
> +
The return type of the method emac_tx_tpd_create() should be void, as
it always returns true.
> +/* Produce new transmit descriptor */
> +static bool emac_tx_tpd_create(struct emac_adapter *adpt,
> + struct emac_tx_queue *tx_q, struct emac_tpd
> *tpd)
> +{
> + u32 *hw_tpd;
> +
> + tx_q->tpd.last_produce_idx = tx_q->tpd.produce_idx;
> + hw_tpd = EMAC_TPD(tx_q, adpt->tpd_size, tx_q->tpd.produce_idx);
> +
> + if (++tx_q->tpd.produce_idx == tx_q->tpd.count)
> + tx_q->tpd.produce_idx = 0;
> +
> + *(hw_tpd++) = tpd->word[0];
> + *(hw_tpd++) = tpd->word[1];
> + *(hw_tpd++) = tpd->word[2];
> + *hw_tpd = tpd->word[3];
> +
> + return true;
> +}
...
...
...
Seems that there are several unused members in the emac_stats struct:
> +struct emac_stats {
...
...
Both rx_bcast_byte_cnt and rx_mcast_byte_cnt are not used anywhere/
> + u64 rx_bcast_byte_cnt; /* broadcast packets byte count (without FCS)
> */
> + u64 rx_mcast_byte_cnt; /* multicast packets byte count (without FCS)
> */
...
rx_err_addr is not used
> + u64 rx_err_addr; /* packets dropped due to address filtering */
Typo: it is jabbers and not jubbers; greppping for "jubber" under
drivers/net/ethernet gives
0 results, whereas:
/net-next/drivers/net/ethernet$ grep -R jabber | wc -l
gives 241 results.
> + u64 rx_jubbers; /* jubbers */
...
..
tx_rd_eop and tx_len_err are not used
> + u64 tx_rd_eop; /* count of reads beyond EOP */
> + u64 tx_len_err; /* packets with length mismatch */
Both tx_bcast_byte and tx_mcast_byte are not used.
> + u64 tx_bcast_byte; /* broadcast packets byte count (without FCS)
> */
> + u64 tx_mcast_byte; /* multicast packets byte count (without FCS)
> */
Thanks for your good work, it seems that the driver is almost done!
Regards,
Rami Rosen
