Mon, Aug 29, 2016 at 08:03:21PM CEST, step...@networkplumber.org wrote: >On Mon, 22 Aug 2016 13:56:25 +0200 >Jiri Pirko <j...@resnulli.us> wrote: > >> From: Yotam Gigi <yot...@mellanox.com> >> >> The matchall classifier matches every packet and allows the user to apply >> actions on it. In addition, it supports the skip_sw and skip_hw (as can >> be found on u32 and flower filter) that direct the kernel to skip the >> software/hardware processing of the actions. >> >> This filter is very useful in usecases where every packet should be >> matched. For example, packet mirroring (SPAN) can be setup very easily >> using that filter. >> >> Signed-off-by: Yotam Gigi <yot...@mellanox.com> >> Signed-off-by: Jiri Pirko <j...@mellanox.com> > >I am not a checkpatch purist, but these two should be addressed. > > >WARNING: unnecessary whitespace before a quoted newline >#81: FILE: tc/f_matchall.c:29: >+ fprintf(stderr, "Usage: ... matchall [skip_sw | skip_hw] \n"); > >WARNING: braces {} are not necessary for single statement blocks >#185: FILE: tc/f_matchall.c:133: >+ if (tb[TCA_MATCHALL_ACT]) { >+ tc_print_action(f, tb[TCA_MATCHALL_ACT]); >+ }
will fix and send v2. Thanks.