From: Daniel Mack
> >> +
> >> +  struct { /* anonymous struct used by BPF_PROG_ATTACH/DETACH commands */
> >> +          __u32           target_fd;      /* container object to attach 
> >> to */
> >> +          __u32           attach_bpf_fd;  /* eBPF program to attach */
> >> +          __u32           attach_type;    /* BPF_ATTACH_TYPE_* */
> >> +          __u64           attach_flags;
> >> +  };
> >
> > there is a 4 byte hole in this struct. Can we pack it differently?
> 
> Okay - I swapped "type" and "flags" to repair this.

That just moves the pad to the end of the structure.
Still likely to cause a problem for 32bit apps on a 64bit kernel.
If you can't think of any flags, why 64 of them?

        David

Reply via email to