On Mon, 2016-09-12 at 07:09 -0700, John Fastabend wrote:
> On 16-09-12 05:19 AM, Hadar Hen Zion wrote:
> > Remove rcu_read_lock protection from tunnel_key_dump and use
> > rtnl_dereference, dump operation is protected by rtnl lock.
> >
> > Also, remove rcu_read_lock from tunnel_key_release and use
> > rcu_dereference_protected.
> >
> > Both operations are running exclusively and a writer couldn't modify
> > t->params while those functions are executed.
> >
> > Fixes: 54d94fd89d90 ('net/sched: Introduce act_tunnel_key')
> > Signed-off-by: Hadar Hen Zion <[email protected]>
> > ---
>
> Thanks for cleaning this up.
>
> Acked-by: John Fastabend <[email protected]>
Exactly, we now have a nice canonical net/sched/act_... component.
Acked-by: Eric Dumazet <[email protected]>
Thanks guys.
