On Wed, Sep 14, 2016 at 11:15:37PM -0700, Christoph Hellwig wrote: > On Thu, Sep 15, 2016 at 12:10:10AM +0000, Adit Ranadive wrote: > > On Wed, Sep 14, 2016 at 05:49:50 -0700 Christoph Hellwig wrote: > > > > + props->max_fmr = dev->dsr->caps.max_fmr; > > > > + props->max_map_per_fmr = dev->dsr->caps.max_map_per_fmr; > > > > > > Please don't add FMR support to any new drivers. > > > > We don't and our device reports these as 0. If you want me to more explicit > > I > > can remove the zero'd out properties. > > Oh, ok. I'll withdraw my comment then.
I would suggest to remove zero assignments to struct which is zero from the beginning. It will eliminate the confusions. Thanks > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Description: PGP signature