Minor nits.
On Thu, 25 May 2006 03:48:38 -0700 (PDT)
"Linsys Contractor Amit S. Kale" <[EMAIL PROTECTED]> wrote:
> +/*
> + * Note: This change will be reflected in all the four ports as there is
> + * only one common adapter.
> + */
> +static int
> +netxen_nic_set_ringparam(struct net_device *dev, struct ethtool_ringparam
> *ring)
> +{
> + return 0;
> +}
Why not just return have no hook if you can't set parameters. Then the ioctl
will return not supported -EOPNOTSUPP
>
> +static u32 netxen_nic_get_rx_csum(struct net_device *dev)
> +{
> + return (dev->features & NETIF_F_HW_CSUM);
> +}
You got receive and transmit checksum confused. You need to separate
checksumming on output (dev->features & NETIF_F_HW_CSUM) versus receive
checksum (controlled by hardware and usually a flag in private data structure).
> +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data)
> +{
> + if (data)
> + dev->features |= NETIF_F_HW_CSUM;
> + else
> + dev->features &= (~NETIF_F_HW_CSUM);
> +
> + if (netif_running(dev)) {
> + dev->stop(dev); /* verify */
> + dev->open(dev);
What if open fail fails? Then you have an "interesting" recovery
situation.
> + }
> + return 0;
> +}
>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
