> +static int __devinit
> +netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> +#if defined(CONFIG_PCI_MSI)
> + adapter->flags |= NETXEN_NIC_MSI_ENABLED;
> + if (pci_enable_msi(pdev)) {
> + adapter->flags &= ~NETXEN_NIC_MSI_ENABLED;
> + printk(KERN_WARNING "%s: unable to allocate MSI interrupt"
> + " error\n", netxen_nic_driver_name);
> + }
> +#endif
No need for the #ifdef -- pci_enable_msi() is stubbed out so it will
always just return failure if CONFIG_PCI_MSI is not set.
> + adapterlist[netxen_cards_found++] = adapter;
> + adapter->number = netxen_cards_found;
Having a static array of adapters is a bad idea. Just allocate a
data structure for each card as you probe it.
- R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
