On ife encode side, external mac header is copied from the original packet
and may be overridden if the user requests. Before, the mac header copy
was done from memory region that might not be accessible anymore, as
skb_cow_head might free it and copy the packet. This led to random values
in the external mac header once the values were not set by user.

This fix takes the internal mac header from the packet, after the call to

Fixes: ef6980b6becb ("net sched: introduce IFE action")
Signed-off-by: Yotam Gigi <yot...@mellanox.com>
 net/sched/act_ife.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
index 27b19ca..7f71a3d 100644
--- a/net/sched/act_ife.c
+++ b/net/sched/act_ife.c
@@ -758,8 +758,6 @@ static int tcf_ife_encode(struct sk_buff *skb, const struct 
tc_action *a,
                return TC_ACT_SHOT;
-       iethh = eth_hdr(skb);
        err = skb_cow_head(skb, reserve);
        if (unlikely(err)) {
@@ -768,6 +766,7 @@ static int tcf_ife_encode(struct sk_buff *skb, const struct 
tc_action *a,
        __skb_push(skb, total_push);
+       iethh = (struct ethhdr *)(skb->data + hdrm);
        memcpy(skb->data, iethh, skb->mac_len);
        skboff += skb->mac_len;

Reply via email to