Hello. On 09/26/2016 10:11 PM, Albert ARIBAUD (3ADEV) wrote:
If the MDIO enf-of-transfer wait loop does not time out, 0 should be returned to the caller through ret, but ret was not reset to 0 after receiving the return value of pm_runtime_get_sync(). Reset ret when no time out occurred. Signed-off-by: Albert ARIBAUD (3ADEV) <albert.arib...@3adev.fr> --- drivers/net/ethernet/freescale/fec_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 01f7e81..0413c05 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1818,6 +1818,8 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, netdev_err(fep->netdev, "MDIO write timeout\n"); ret = -ETIMEDOUT; } + else
} else {
+ ret = 0;
} [...] MBR, Sergei