Hi Andrew, Thank you for review comments. I accepted your review comment and change the code. I resent for code review.
Thanks, Raju. On Tue, Oct 04, 2016 at 02:53:19PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > Regarding remove the -'s in table, PHY data sheet descript the > > concept of edge rate with table. I would like to keep the same table > > in driver. > > The double negative makes the code ugly. Plus a negative slowdown is a > speed up! The kernel maintainability and sanity comes first, and if > the data sheet is crazy, because it uses negative slows downs, it > should be ignored. Get the data sheet fixed.... > > Andrew
