From: Roopa Prabhu <ro...@cumulusnetworks.com>

This patch adds vlan and address to warning messages printed
in the bridge fdb code for debuggability.

Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com>
---
v2 - address comments from stephen
        - use %u format specifier for vlan
        - move print string to a single line

 net/bridge/br_fdb.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 6b43c8c..e4a4176 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -535,9 +535,8 @@ static int fdb_insert(struct net_bridge *br, struct 
net_bridge_port *source,
                 */
                if (fdb->is_local)
                        return 0;
-               br_warn(br, "adding interface %s with same address "
-                      "as a received packet\n",
-                      source ? source->dev->name : br->dev->name);
+               br_warn(br, "adding interface %s with same address as a 
received packet (addr:%pM, vlan:%u)\n",
+                      source ? source->dev->name : br->dev->name, addr, vid);
                fdb_delete(br, fdb);
        }
 
@@ -583,9 +582,8 @@ void br_fdb_update(struct net_bridge *br, struct 
net_bridge_port *source,
                /* attempt to update an entry for a local interface */
                if (unlikely(fdb->is_local)) {
                        if (net_ratelimit())
-                               br_warn(br, "received packet on %s with "
-                                       "own address as source address\n",
-                                       source->dev->name);
+                               br_warn(br, "received packet on %s with own 
address as source address (addr:%pM, vlan:%u)\n",
+                                       source->dev->name, addr, vid);
                } else {
                        /* fastpath: update of existing entry */
                        if (unlikely(source != fdb->dst)) {
-- 
1.9.1

Reply via email to