On Tue, Oct 18, 2016 at 8:44 AM,  <f...@ikuai8.com> wrote:
> From: Gao Feng <f...@ikuai8.com>
>
> Use sizeof variable instead of literal number to enhance the readability.
>
> Signed-off-by: Gao Feng <f...@ikuai8.com>
> ---
>  net/8021q/vlan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index 8de138d..5a3903b 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -515,8 +515,8 @@ static int vlan_ioctl_handler(struct net *net, void 
> __user *arg)
>                 return -EFAULT;
>
>         /* Null terminate this sucker, just in case. */
> -       args.device1[23] = 0;
> -       args.u.device2[23] = 0;
> +       args.device1[sizeof(args.device1) - 1] = 0;
> +       args.u.device2[sizeof(args.u.device2) - 1] = 0;
>
>         rtnl_lock();
>
> --
> 1.9.1
>
>

Sorry, I forget add the "net-next" in the title.
Now I have sent another new patch, please ignore this conversation.

Regards
Feng

Reply via email to