From: Aaron Conole <acon...@bytheb.org>

The virtio committee recently ratified a change, VIRTIO-152, which
defines the mtu field to be 'max' MTU, not simply desired MTU.

This commit brings the virtio-net device in compliance with VIRTIO-152.

Additionally, drop the max_mtu branch - it cannot be taken since the u16
returned by virtio_cread16 will never exceed the initial value of
max_mtu.

Cc: "Michael S. Tsirkin" <m...@redhat.com>
Cc: Jarod Wilson <ja...@redhat.com>
Signed-off-by: Aaron Conole <acon...@redhat.com>
---
 drivers/net/virtio_net.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 720809f..2cafd12 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1870,10 +1870,12 @@ static int virtnet_probe(struct virtio_device *vdev)
                mtu = virtio_cread16(vdev,
                                     offsetof(struct virtio_net_config,
                                              mtu));
-               if (mtu < dev->min_mtu || mtu > dev->max_mtu)
+               if (mtu < dev->min_mtu) {
                        __virtio_clear_bit(vdev, VIRTIO_NET_F_MTU);
-               else
+               } else {
                        dev->mtu = mtu;
+                       dev->max_mtu = mtu;
+               }
        }
 
        if (vi->any_header_sg)
-- 
2.7.4

Reply via email to