On Sat, 2016-10-29 at 10:17 +0200, Paolo Abeni wrote: > Thank you for working on this. > > I just gave a very quick look (the WE has started, children are > screaming ;-), overall the implementation seems quite similar to our > one. > > I like the additional argument to ip_cmsg_recv_offset() instead of > keeping skb->sk set. > > If I read udp_skb_destructor() correctly, the atomic manipulation of > both sk_rmem_alloc and udp_memory_allocated will happen under the > receive lock. In our experiments this increment measurably the > contention on the lock in respect to moving said the operations outside > the lock (as done in our patch). Do you foreseen any issues with that ? > AFAICS every in kernel UDP user of skb_recv_datagram() needs to be > updated with both implementation.
So if you look at tcp, we do not release forward allocation at every recvmsg(), but rather when we are under tcp memory pressure, or at timer firing when we know the flow has been idle for a while. You hit contention on the lock, but the root cause is that right now udp is very conservative and also hits false sharing on udp_memory_allocated. So I believe this is another problem which needs a fix anyway. No need to make a complicated patch right now, if we know that this problem will be separately fixed, in another patch ?
