Re: [PATCH 1/9] NetXen 1G/10G ethernet driver patch with corrections

[Andi Kleen]

On Wednesday 07 June 2006 11:39, Linsys Contractor Amit S. Kale wrote:

> +     switch (mode) {

... You could save a lot of code by using a table and a loop over the registers.


> +     case 4:{                /* XGB Mode */
> +                     NETXEN_NIC_LOCKED_READ_REG(NETXEN_NIU_XG_SINGLE_TERM,
> +                                                &regs_buff[3]);


-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html