Re: [PATCH net-next 07/11] net: dsa: mv88e6xxx: add port link setter

[Andrew Lunn]

> +#define LINK_UNKNOWN -1
> +
> +     /* Port's MAC link state
> +      * LINK_UNKNOWN for normal link detection, 0 to force link down,
> +      * otherwise force link up.
> +      */
> +     int (*port_set_link)(struct mv88e6xxx_chip *chip, int port, int link);

Hi Vivien

Maybe LINK_AUTO would be better than UNKNOWN? Or LINK_UNFORCED.

      Andrew