Hi David,
On Thu, Nov 10, 2016 at 11:57:18AM -0500, David Miller wrote:
> From: Baruch Siach <[email protected]>
> Date: Wed, 9 Nov 2016 14:56:33 +0200
>
> > Current .ndo_set_mac_address implementation brings up the interface when
> > revert
> > to original address after failure succeeds. Fix this.
> >
> > Signed-off-by: Baruch Siach <[email protected]>
> > ---
> > Untested; I don't have the hardware.
>
> The code which updates the parser should keep the existing
> state if any part of the update fails.
>
> This means it must attempt all memory allocations and whatever other
> resource acquisition is necessary, and only after all of those
> operations succeed and no more error cases are possible should it
> update the tables and release the old entry.
>
> In other worse, this whole mechanism must move to a proper "prepare
> --> commit" model of making changes.
Doing so is possible, but requires much larger changes in the driver code.
This patch makes the minimal fix to a clear bug. It should be an improvement
over the current state.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
