On 26/11/16 00:58, kbuild test robot wrote:
> Hi Edward,
>
> [auto build test ERROR on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-split-out-Falcon-driver/20161126-033439
> config: i386-randconfig-h1-11260702 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> Note: the
> linux-review/Edward-Cree/sfc-split-out-Falcon-driver/20161126-033439 HEAD
> 738d215da7cf33cb4f2916dfba4fdb1558829e5a builds fine.
> It only hurts bisectibility.
>
> All error/warnings (new ones prefixed by >>):
>
> drivers/net/ethernet/sfc/falcon/built-in.o: In function
> `tenxpress_set_id_led':
>>> (.text+0x28db4): multiple definition of `tenxpress_set_id_led'
> drivers/net/ethernet/sfc/built-in.o:(.text+0x3bac7): first defined here
Right, I have to do at least some of the rip-stuff-out in the first patch, else
building both drivers built-in breaks. (I only tested building them as modules,
that was silly of me.)
Wondering if the right thing to do is just squash both patches together: it
could hardly make the series _less_ reviewable, and it might help git recognise
more of the copies as file renames.
Opinions?
-Ed
