On 11/29/2016 08:50 PM, Josef Bacik wrote:
On 11/29/2016 02:06 PM, Daniel Borkmann wrote:
On 11/29/2016 06:35 PM, Josef Bacik wrote:
This is a test to verify that
bpf: fix states equal logic for varlen access
actually fixed the problem. The problem was if the register we added to our map
register was UNKNOWN in both the false and true branches and the only thing that
changed was the range then we'd incorrectly assume that the true branch was
valid, which it really wasnt. This tests this case and properly fails without
my fix in place and passes with it in place.
Signed-off-by: Josef Bacik <[email protected]>
Acked-by: Daniel Borkmann <[email protected]>
Thanks a lot for the test case! They are always useful to have ... which
just reminds me: it seems we didn't add anything for f23cc643f9ba ("bpf:
fix range arithmetic for bpf map access"). ;-)
I was hoping you wouldn't notice ;). I'll add one in the next couple of days.
Thanks,
Awesome, thanks a lot! :-)
