Re: [PATCH] stmmac: simplify flag assignment

[Giuseppe CAVALLARO]

+ Alex

On 11/30/2016 12:44 PM, Pavel Machek wrote:

Simplify flag assignment.

Signed-off-by: Pavel Machek <pa...@denx.de>

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index ed20668..0b706a7 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -2771,12 +2771,8 @@ static netdev_features_t stmmac_fix_features(struct 
net_device *dev,
                features &= ~NETIF_F_CSUM_MASK;

        /* Disable tso if asked by ethtool */
-       if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) {
-               if (features & NETIF_F_TSO)
-                       priv->tso = true;
-               else
-                       priv->tso = false;
-       }
+       if ((priv->plat->tso_en) && (priv->dma_cap.tsoen))
+               priv->tso = !!(features & NETIF_F_TSO);

        return features;
 }