Re: [PATCH net] net: dsa: mv88e6xxx: Fix opps when adding vlan bridge

[Vivien Didelot]

Hi Andrew,

Andrew Lunn <and...@lunn.ch> writes:

> @@ -1804,6 +1807,9 @@ static int mv88e6xxx_port_check_hw_vlan(struct 
> dsa_switch *ds, int port,
>                           chip->ports[port].bridge_dev)
>                               break; /* same bridge, check next VLAN */
>  
> +                     if (!chip->ports[i].bridge_dev)
> +                             continue;
> +

The above truncated test:

                        if (chip->ports[i].bridge_dev ==
                            chip->ports[port].bridge_dev)
                                break; /* same bridge, check next VLAN */

should handle the case where bridge_dev is NULL, but if you want to
explicitly test it, I'd move it before this statement.

>                       netdev_warn(ds->ports[port].netdev,
>                                   "hardware VLAN %d already used by %s\n",
>                                   vlan.vid,


Thanks,

        Vivien