On Thu, 12 Jan 2017 15:22:49 +0100 Phil Sutter <p...@nwl.cc> wrote: > Said iptables version introduced struct xtables_globals field > 'compat_rev', a function pointer. Initializing it is mandatory as > libxtables calls it without existence check. > > Without this, tc segfaults when using the xt action like so: > > | tc filter add dev d0 parent ffff: u32 match u32 0 0 \ > | action xt -j MARK --set-mark 20 > > Signed-off-by: Phil Sutter <p...@nwl.cc> > --- > tc/m_xt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tc/m_xt.c b/tc/m_xt.c > index dbb54981462ee..57ed40d7aa3a8 100644 > --- a/tc/m_xt.c > +++ b/tc/m_xt.c > @@ -77,6 +77,9 @@ static struct xtables_globals tcipt_globals = { > .orig_opts = original_opts, > .opts = original_opts, > .exit_err = NULL, > +#if (XTABLES_VERSION_CODE >= 11) > + .compat_rev = xtables_compatible_revision, > +#endif > }; > > /*
Ah the xtables API is not really an application friendly API by any stretch of the imagination Parenthesis not really necessary there.