Thanks Eric.

On 13/01/2017 6:39 PM, Eric Dumazet wrote:
From: Eric Dumazet <eduma...@google.com>

Disable BH around the call to napi_schedule() to avoid following warning

[   52.095499] NOHZ: local_softirq_pending 08
[   52.421291] NOHZ: local_softirq_pending 08
[   52.608313] NOHZ: local_softirq_pending 08

Fixes: 8d59de8f7bb3 ("net/mlx4_en: Process all completions in RX rings after port 
goes up")
Signed-off-by: Eric Dumazet <eduma...@google.com>
Cc: Erez Shitrit <ere...@mellanox.com>
Cc: Eugenia Emantayev <euge...@mellanox.com>
Cc: Tariq Toukan <tar...@mellanox.com>
---
  drivers/net/ethernet/mellanox/mlx4/en_netdev.c |    5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c 
b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 
4910d9af19335d4b97d39760c163b41eecc26242..761f8b12399cab245abccc0f7d7f84fde742c14d
 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -1748,8 +1748,11 @@ int mlx4_en_start_port(struct net_device *dev)
        /* Process all completions if exist to prevent
         * the queues freezing if they are full
         */
-       for (i = 0; i < priv->rx_ring_num; i++)
+       for (i = 0; i < priv->rx_ring_num; i++) {
+               local_bh_disable();
                napi_schedule(&priv->rx_cq[i]->napi);
+               local_bh_enable();
+       }
netif_tx_start_all_queues(dev);
        netif_device_attach(dev);


Acked-by: Tariq Toukan <tar...@mellanox.com>

Reply via email to