On Sun, Jun 25, 2006 at 01:44:36AM -0700, [EMAIL PROTECTED] wrote:
>
> From: Dan Faerch <[EMAIL PROTECTED]>
>
> Adds "ethtool command" support to driver. Initially 2 commands are
> implemented: force fullduplex and toggle autoneg.
This part is good, although doing something for copper cards needs doing,
which probably means poking around to support the phy properly.
> Also added a "disable_autoneg" module argument to completely disable
> autoneg on all cards using this driver.
This is the part I disagree with. Are you sure it isn't a bug in the
link autonegotiation state machine for fibre cards? It should be defaulting
to 1Gbit/full duplex if no autonegotiation is happening, and if it isn't
then that should be fixed instead of papering over things with a config
option.
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <[EMAIL PROTECTED]>.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
