> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, January 18, 2017 1:29 PM > To: Grandhi, Sainath <sainath.gran...@intel.com> > Cc: netdev@vger.kernel.org; mah...@bandewar.net; linux- > ker...@vger.kernel.org > Subject: Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver > > From: Sainath Grandhi <sainath.gran...@intel.com> > Date: Tue, 17 Jan 2017 16:03:06 -0800 > > > +static void ipvtap_count_tx_dropped(struct tap_dev *tap) { > > + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct > > +ipvtap_dev, tap); > ... > > +static void ipvtap_count_rx_dropped(struct tap_dev *tap) { > > + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct > > +ipvtap_dev, tap); > ... > > +static void ipvtap_update_features(struct tap_dev *tap, > > + netdev_features_t features) > > +{ > > + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct > > +ipvtap_dev, tap); > > More unnecessary casts, please remove.
Will take care of it in next revision. Thanks.
