On 31 January 2017 at 19:16, David Miller <da...@davemloft.net> wrote: > From: David Miller <da...@davemloft.net> > Date: Tue, 31 Jan 2017 13:14:52 -0500 (EST) > >> From: Florian Fainelli <f.faine...@gmail.com> >> Date: Tue, 31 Jan 2017 10:06:34 -0800 >> >>> On 01/31/2017 10:04 AM, David Miller wrote: >>>> >>>> This entire series is being held up because there is still questions about >>>> whether this is programming the internal PHYs and therefore whether the >>>> code should be placed elsewhere. >>>> >>>> Can we please move the discussion forward? >>> >>> The patches are good as-is, we can resolve the PHY programming later on >>> when we have figured out the details of the 4749 chip we derailed on. >> >> Ok great, series applied, thanks. > > Actually, reverted, I get build failures: > > [davem@dhcp-10-15-49-210 net-next]$ make -s -j8 > DESCEND objtool > Setup is 17084 bytes (padded to 17408 bytes). > System is 10211 kB > CRC 68863231 > Kernel: arch/x86/boot/bzImage is ready (#139) > ERROR: "bgmac_alloc" [drivers/net/ethernet/broadcom/bgmac-platform.ko] > undefined! > ERROR: "bgmac_alloc" [drivers/net/ethernet/broadcom/bgmac-bcma.ko] undefined! > scripts/Makefile.modpost:91: recipe for target '__modpost' failed > make[1]: *** [__modpost] Error 1 > Makefile:1196: recipe for target 'modules' failed > make: *** [modules] Error 2
Sorry! :( I'm working on this. Shit, I should have resent this after adding devm_alloc_etherdev to let kbuild test it. -- Rafał
