Re: [PATCH RFC ipsec-next 5/5] esp: Add a software GRO codepath

[David Miller]

From: Steffen Klassert <steffen.klass...@secunet.com>
Date: Tue, 7 Feb 2017 10:14:11 +0100

> +static struct sk_buff **esp4_gro_receive(struct sk_buff **head,
> +                                      struct sk_buff *skb)
> +{
> +     int err;
> +     __be32 seq;
> +     __be32 spi;
> +     struct xfrm_state *x;
> +     int offset = skb_gro_offset(skb);

Please order local variable declarations from longest to shortest.

> +static struct sk_buff **esp6_gro_receive(struct sk_buff **head,
> +                                      struct sk_buff *skb)
> +{
> +     int err;
> +     __be32 seq;
> +     __be32 spi;
> +     struct xfrm_state *x;
> +     int offset = skb_gro_offset(skb);

Likewise.

Thank you.