On 24/02/2017 1:22 AM, Eric Dumazet wrote:
From: Eric Dumazet <eduma...@google.com>

The cited commit makes a great job of finding optimal shift/multiplier
values assuming a 10 seconds wrap around, but forgot to change the
overflow_period computation.

It overflows in cyclecounter_cyc2ns(), and the final result is 804 ms,
which is silly.

Lets simply use 5 seconds, no need to recompute this, given how it is
supposed to work.

Later, we will use a timer instead of a work queue, since the new RX
allocation schem will no longer need mlx4_en_recover_from_oom() and the
service_task firing every 250 ms.

Fixes: 31c128b66e5b ("net/mlx4_en: Choose time-stamping shift value according to HW 
frequency")
Signed-off-by: Eric Dumazet <eduma...@google.com>
Cc: Tariq Toukan <tar...@mellanox.com>
Cc: Eugenia Emantayev <euge...@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlx4/en_clock.c |   18 +++++++---------
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h  |    1
 2 files changed, 8 insertions(+), 11 deletions(-)


Reviewed-by: Tariq Toukan <tar...@mellanox.com>

Thanks for your patch.

Reply via email to