Hi,

> Yea, I admit, the original color palette is kind of horrendous. I
> wouldn't say the current colors are suitable for a light background
> either.

> I propose you just replace the current colors with their bold
> variants, and leave the background hue guessing out all together. That
> would be an all-round improvement for everyone.
Well, I agree that original colors aren't the best ones for a light background 
either, but
not all bold variants are suitable for light background - yellow, white and 
cyan are
problematic at least on some terminals with light background (e.g. konsole; 
white isn't
used). So I'd really keep separate sets of colors.

> I'll include some comments on this patch-set anyway, as I had a look
> at it.
Thanks for your review, I'll post fixed version with two sets of colors.


Kind regards,
Petr

Reply via email to