On Tue, 2006-04-07 at 15:29 +0200, Patrick McHardy wrote: > Russell Stuart wrote: [..] > > Without seeing your actual proposal it is difficult to > > judge whether this is a reasonable trade-off or not. > > Hopefully we will see your code soon. Do you have any > > idea when? > > Unfortunately I still didn't got to cleaning them up, so I'm sending > them in their preliminary state. Its not much that is missing, but > the netem usage of skb->cb needs to be integrated better, I failed > to move it to the qdisc_skb_cb so far because of circular includes. > But nothing unfixable. I'm mostly interested if the current size-tables > can express what you need for ATM, I wasn't able to understand the > big comment in tc_core.c in your patch. >
Looks good from within the range of "change within reason" of addressed problem. The cb on the qdisc seems only usable for netem, correct? Also while not unreasonable, i wasnt sure how qdisc_enqueue_root() fit in the grand scheme of things for this change (it seemed out of place). cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
