Re: [net-next:master 53/61] net/sched/sch_tbf.c:399:3: note: in expansion of macro 'if'

[David Miller]

From: kbuild test robot <fengguang...@intel.com>
Date: Mon, 13 Mar 2017 14:49:27 +0800

>>> net/sched/sch_tbf.c:399:3: note: in expansion of macro 'if'
>       if (child != &noop_qdisc);
>       ^~
>    net/sched/sch_tbf.c:400:4: note: ...this statement, but the latter is 
> misleadingly indented as if it is guarded by the 'if'
>        qdisc_hash_add(child, true);
>        ^~~~~~~~~~~~~~

Now fixes as follows:

====================
[PATCH] sch_tbf: Remove bogus semicolon in if() conditional.

Fixes: 49b499718fa1 ("net: sched: make default fifo qdiscs appear in the dump")
Reported-by: kbuild test robot <fengguang...@intel.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
---
 net/sched/sch_tbf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
index 40c29a8..9850126 100644
--- a/net/sched/sch_tbf.c
+++ b/net/sched/sch_tbf.c
@@ -396,7 +396,7 @@ static int tbf_change(struct Qdisc *sch, struct nlattr *opt)
                                          q->qdisc->qstats.backlog);
                qdisc_destroy(q->qdisc);
                q->qdisc = child;
-               if (child != &noop_qdisc);
+               if (child != &noop_qdisc)
                        qdisc_hash_add(child, true);
        }
        q->limit = qopt->limit;
-- 
2.1.0