> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On
> Behalf Of Colin King
> Sent: Monday, March 20, 2017 7:46 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; intel-wired-
> l...@lists.osuosl.org; netdev@vger.kernel.org
> Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] i40e: fix memcpy with swapped arguments
>
> From: Colin Ian King <colin.k...@canonical.com>
Hi there,
>
> The current code copies an uninitialized params into
> cdev->lan_info.params and then passes the uninitialized params
> to the call cdev->client->ops->l2_param_change. I believe the
> order of the source and destination in the memcpy is the wrong
> way around and should be swapped.
>
So you are correct that params is uninitialized. However, the fix here is not
correct. Somehow we dropped the code for initializing the parameters.
See commit d7ce6422d6e6 ("i40e: don't check params until after checking for
client instance", 2017-02-09) It looks like the commit itself was malformed
when applied upstream, and a later commit which should have preserved the
changes 3140aa9a78c9 ("i40e: KISS the client interface", 2017-03-14)
accidentally dropped them.
I'll provide a patch to get this back into the correct state.
Thanks for catching this.
Regards,
Jake
