On Mon, Mar 27, 2017 at 11:03:12AM -0700, Florian Fainelli wrote:
> On 03/27/2017 10:00 AM, Russell King - ARM Linux wrote:
> > On Mon, Mar 27, 2017 at 09:47:31AM -0700, Florian Fainelli wrote:
> >> On 03/27/2017 02:59 AM, Russell King wrote:
> >>> As EEE is able to work in SGMII mode as well, add it to the list of
> >>> permissable EEE modes that phy_init_eee() will accept. This is
> >>> necessary so that EEE can work with an 88E1512 connected in SGMII mode.
> >>
> >> As you mention in your cover letter, we should probably reverse this
> >> test and make it reject modes where EEE has no chance of being supported
> >> at all.
> >
> > Want me to re-spin? Any thought on which interface modes we should
> > explicitly exclude?
>
> It actually sounds like we should just kill the check entirely, it does
> not appear that any of the interface mode would not fundamentally be
> able to support EEE, because the "lowest" mode we support is MII, and
> even there it's quite possible to support EEE.
Right, so it looks like the test reduces down to just:
if (phydev->duplex == DUPLEX_FULL) {
agreed?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
