On Tue, 2017-03-28 at 03:09 +0200, Andrew Lunn wrote: > On Tue, Mar 28, 2017 at 11:49:50AM +1100, Benjamin Herrenschmidt wrote: > > Hi ! > > > > I noticed that flow control isn't being enabled on a system I'm > > working on by default. I've tracked it down to two things: > > > > - The realtec.c PHY driver doesn't have Pause or Asym_Pause in > > its exposed capabilities. This is in part because PHY_GBIT_FEATURES > > does not include SUPPORTED_Pause and SUPPORTED_Asym_Pause. Is there > > a specific reason for that ? > > Hi Ben > > It is worth reading Documentation/networking/phy.txt > > The MAC should set SUPPORTED_Pause and SUPPORTED_Asym_Pause if the MAC > supports these features. The PHY will then negotiate them.
Ok. I had added them but hit the other issue with the 1000bT style pause. Cheers, Ben.
