Hi Sunil - this implementation was verified with multiple adapters installed. In this case, the <id> field serves to differentiate the adapter.
> LiquidIO<id>-<func>-<type>-<queue pair num> Rick -----Original Message----- From: Sunil Kovvuri [mailto:sunil.kovv...@gmail.com] Sent: Monday, April 03, 2017 2:56 AM To: Manlunas, Felix <felix.manlu...@cavium.com> Cc: David S. Miller <da...@davemloft.net>; Linux Netdev List <netdev@vger.kernel.org>; Vatsavayi, Raghu <raghu.vatsav...@cavium.com>; Chickles, Derek <derek.chick...@cavium.com>; Burla, Satananda <satananda.bu...@cavium.com>; Ricardo Farrington <ricardo.farring...@cavium.com> Subject: Re: [PATCH net-next] liquidio: use meaningful names for IRQs On Tue, Mar 14, 2017 at 1:28 AM, Felix Manlunas <felix.manlu...@cavium.com> wrote: > From: Rick Farrington <ricardo.farring...@cavium.com> > > All IRQs owned by the PF and VF drivers share the same nondescript > name "octeon"; this makes it difficult to setup interrupt affinity. > > Change the IRQ names to reflect their specific purpose: > > LiquidIO<id>-<func>-<type>-<queue pair num> > > Examples: > LiquidIO0-pf0-rxtx-3 > LiquidIO1-vf1-rxtx-0 > LiquidIO0-pf0-aux Probably too late, but just my 2 cents. If there are multiple LiquidIO cards connected in a system, wouldn't the same issue of how to setup IRQ affinities arise ? How do you map netdev->name to IRQ name ? > > We cannot use netdev->name for naming the IRQs because: > > 1. Early during init, the PF and VF drivers require interrupts to > send/receive control data from the NIC firmware; so the PF and VF > must request IRQs long before the netdev struct is registered. > > 2. The IRQ name can only be specified at the time it is requested. > It cannot be changed after that. You can try splitting IRQ registration and register IRQs for sending/receiving control data with above naming but for queues, IRQs can be registered after netdev struct is registered. Thanks, Sunil.
