On Mon, 24 Apr 2017 20:58:18 -0400, Jamal Hadi Salim wrote: > On 17-04-24 02:32 PM, David Miller wrote: > > From: Benjamin LaHaise <[email protected]> > > > > > Series applied, but in the future: > > > > 1) Put the "v2", "v3", whatever in the inital [PATCH xxx] bracketed > > part of the subject line, otherwise it ends up in the GIT commit > > message header line and that's not desired. > > > > 2) Please cut it with these double signoffs, and add an appropriate > > entry to the email aliases file. > > I know i should have spoken earlier, wanted to but got distracted - but > shouldnt the new rules have applied to this patch too? ;-> > > You have 3 TLVs, one of which is u8 that only allows use of 3 bits. > The other is a u32 which allows only 20 bits to be set.
I don't think we will ever reuse bits in a field which is called MPLS_LABEL for anything else than an MPLS label. My understanding of the conclusions from recent discussions was to either (a) make attributes single purpose (i.e. separate u8 per flag); or (b) make attributes u32/word size but validate the unused bits are zero. This patch would fall under (a).
