On 5/2/17 9:25 AM, Stephen Hemminger wrote: > Please either use existing netlink attribute code in libnetlink.h > (rta_getattr_u32 etc) or use libmnl like devlink.
All of the existing rta_ functions take a struct rta_attr; netlink messages use struct nlattr. It's just wrong to use rta functions for netlink messages. There is no existing parse function for nlattr. There is no existing validate function - for nlattr or rta_attr. So I do not see any overlap with existing code. If you prefer ip to gain a dependency on libmnl, I'll take a look.
