On 05/03/2017 02:28 PM, Quentin Schulz wrote: > Hi Marc, > > On 03/05/2017 14:16, Marc Kleine-Budde wrote: >> On 05/03/2017 02:11 PM, Quentin Schulz wrote: >>> This adds Power Management deep Suspend/Resume support for Bosch M_CAN >>> chip. >>> >>> When the chip resumes from deep sleep, the RAM needs to be initialized >>> as it is done when the driver probes. The net interface also needs to be >>> closed and reopened to be fully functional. >> >> Are you sure it's the closing and opening of the net interface. Maybe >> it's the m_can_start() and/or the subsequent m_can_chip_config()? >> > > You're right. The chip needs to be completely reinitialized (clocks, > chip itself) and it also closes and reopens the interface if I'm correct > with close_candev and open_candev. > I'm sending a v2 right away to fix the commit log.
:) I mean to fix the call to the proper function and _not_ calling close() open(). Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature