From: Alexei Starovoitov <alexei.starovoi...@gmail.com>
Date: Tue, 2 May 2017 17:53:16 -0700

> On Tue, May 02, 2017 at 02:31:50PM +0200, Jesper Dangaard Brouer wrote:
>> Needed to adjust max locked memory RLIMIT_MEMLOCK for testing these bpf 
>> samples
>> as these are using more and larger maps than can fit in distro default 
>> 64Kbytes limit.
>> 
>> Signed-off-by: Jesper Dangaard Brouer <bro...@redhat.com>
> ...
>> +    struct rlimit r = {1024*1024, RLIM_INFINITY};
> ...
>> +    struct rlimit r = {1024*1024, RLIM_INFINITY};
> 
> why magic numbers?
> All other samples do
> struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};

Let's not do that.

People run these tests often as root, so the safer we make running
these test the better.

A weird magic limit is better than none at all.

Reply via email to