On Fri, 2017-05-05 at 11:36 +0200, Florian Westphal wrote: > Eric Dumazet <eric.duma...@gmail.com> wrote: > > From: Eric Dumazet <eduma...@google.com> > > > > Whole point of randomization was to hide server uptime, but an attacker > > can simply start a syn flood and TCP generates 'old style' timestamps, > > directly revealing server jiffies value. > > > > Also, TSval sent by the server to a particular remote address vary > > depending on syncookies being sent or not, potentially triggering PAWS > > drops for innocent clients. > > > > Lets implement proper randomization, including for SYNcookies. > > > Thanks a lot Eric, this works for me (I also tested ipv6 this time ;) ) > > Minor nit: > net/ipv4/tcp_ipv4.c:154:6: warning: unused variable 'seq' [-Wunused-variable] >
Thanks Florian, I will remove this in v3, and add your tags. > Other than this: > Reviewed-by: Florian Westphal <f...@strlen.de> > Tested-by: Florian Westphal <f...@strlen.de>
