From: Daniel Borkmann <[email protected]>
Date: Thu, 11 May 2017 14:53:58 +0200
> On 05/10/2017 09:09 PM, David Miller wrote:
>> @@ -3574,6 +3581,10 @@ int bpf_check(struct bpf_prog **prog, union
>> bpf_attr *attr)
>> } else {
>> log_level = 0;
>> }
>> + if (attr->prog_flags & BPF_F_STRICT_ALIGNMENT)
>> + strict_alignment = true;
>> + else
>> + strict_alignment = false;
>
> Just minor nit: Can we move this into struct bpf_verifier_env
> here instead of global var? The only change it would need is
> in check_ptr_alignment() to pass the env from check_mem_access().
> check_ptr_alignment() can then infer this from env.
I was just being lazy and doing it the way bpf_log is done. :-)
I've moved it into bpf_verifier_env, no problem.
> Rest looks good:
>
> Acked-by: Daniel Borkmann <[email protected]>
Thanks again for review.
