From: Felix Manlunas <felix.manlu...@cavium.com> Date: Tue, 16 May 2017 11:14:50 -0700
> From: Rick Farrington <ricardo.farring...@cavium.com> > > When multiple liquidio NICs are plugged in, the first insmod of the PF > driver succeeds. But after an rmmod, a subsequent insmod fails. Reason is > during rmmod, the PF driver resets the Octeon of only one of the NICs; it > neglects to reset the Octeons of the other NICs. > > Fix the insmod failure by adding the missing Octeon resets at rmmod. Keep > a per-NIC refcount that indicates the number of active PFs in a given NIC. > When the refcount goes to zero, then reset the Octeon of that NIC. > > Signed-off-by: Rick Farrington <ricardo.farring...@cavium.com> > Signed-off-by: Felix Manlunas <felix.manlu...@cavium.com> I'm applying this but I'm really not happy with how this driver handles probing. There is no reason to have arbitrary limits to the number of adapters, everything should be dynamic and allow arbitrary numbers of instances even if that is not physically possible with current hardware. Also, the driver should be able to load even if something isn't reset properly. A boot loader or some other entity could have programmed the device or something like a kdump kernel could leave it in an indeterminate state. So you must be able to probe the device even if it has not been soft reset properly. In fact, the soft reset probably should happen during probe not during shutdown.
