> -----Original Message----- > From: David Miller [mailto:[email protected]] > Sent: Monday, May 22, 2017 7:38 PM > To: Mintz, Yuval <[email protected]> > Cc: [email protected]; Chopra, Manish <[email protected]> > Subject: Re: [PATCH net-next 01/11] qede: Fix sparse warnings > > From: Yuval Mintz <[email protected]> > Date: Mon, 22 May 2017 14:32:01 +0300 > > > From: Manish Chopra <[email protected]> > > > > Signed-off-by: Manish Chopra <[email protected]> > > Signed-off-by: Yuval Mintz <[email protected]> > > --- > > drivers/net/ethernet/qlogic/qede/qede_dcbnl.c | 1 - > > drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 10 ++++++---- > > drivers/net/ethernet/qlogic/qede/qede_fp.c | 25 ++++++++++++++------- > ---- > > drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++-- > > 4 files changed, 22 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c > > b/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c > > index a9e7379..6e7747b 100644 > > --- a/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c > > +++ b/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c > > @@ -313,7 +313,6 @@ static int qede_dcbnl_ieee_peer_getets(struct > net_device *netdev, > > .ieee_setets = qede_dcbnl_ieee_setets, > > .ieee_getapp = qede_dcbnl_ieee_getapp, > > .ieee_setapp = qede_dcbnl_ieee_setapp, > > - .getdcbx = qede_dcbnl_getdcbx, > > .ieee_peer_getpfc = qede_dcbnl_ieee_peer_getpfc, > > .ieee_peer_getets = qede_dcbnl_ieee_peer_getets, > > .getstate = qede_dcbnl_getstate, > > Please. > > This is exactly the problem when such a terse commit message, or lack of any > message at all as is the case here, occurs. > > I have no idea what removing this method assignment has to do with fixing > sparse warnings.
It's currently defined twice in the qede_dcbnl_ops struct - .ieee_setapp = qede_dcbnl_ieee_setapp, .getdcbx = qede_dcbnl_getdcbx, .ieee_peer_getpfc = qede_dcbnl_ieee_peer_getpfc, ... .getapp = qede_dcbnl_getapp, .getdcbx = qede_dcbnl_getdcbx, .setpgtccfgtx = qede_dcbnl_setpgtccfgtx,
