Hi Andrew, Andrew Lunn <and...@lunn.ch> writes:
> The upcoming SERDES support will need to make use of PHY functions. Move > them out into a file of there own. No code changes. their [...] > +int mv88e6xxx_phy_page_get(struct mv88e6xxx_chip *chip, int phy, u8 page); > +void mv88e6xxx_phy_page_put(struct mv88e6xxx_chip *chip, int phy); I am not sure that you need to expose these functions. Can you confirm? > +int mv88e6xxx_phy_page_read(struct mv88e6xxx_chip *chip, int phy, > + u8 page, int reg, u16 *val); > +int mv88e6xxx_phy_page_write(struct mv88e6xxx_chip *chip, int phy, > + u8 page, int reg, u16 val); > +int mv88e6xxx_ppu_disable(struct mv88e6xxx_chip *chip); > +int mv88e6xxx_ppu_enable(struct mv88e6xxx_chip *chip); > +void mv88e6xxx_ppu_state_init(struct mv88e6xxx_chip *chip); > +void mv88e6xxx_ppu_state_destroy(struct mv88e6xxx_chip *chip); If we want to move all PHY-related functions and wrappers into phy.[ch], there are also mv88e6xxx_phy_init and mv88e6xxx_phy_destroy. This will make most mv88e6xxx_ppu_* code static. > +int mv88e6xxx_phy_ppu_read(struct mv88e6xxx_chip *chip, struct mii_bus *bus, > + int addr, int reg, u16 *val); > +int mv88e6xxx_phy_ppu_write(struct mv88e6xxx_chip *chip, struct mii_bus *bus, > + int addr, int reg, u16 val); Thanks, Vivien