Hi Andrew, On Thu, Jun 08, 2017 at 06:03:31PM +0200, Andrew Lunn wrote: > On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote: > > +#define MVMDIO_XSMI_MGNT_REG 0x0 > > +#define MVMDIO_XSMI_READ_VALID BIT(29) > > +#define MVMDIO_XSMI_BUSY BIT(30) > > +#define MVMDIO_XSMI_ADDR_REG 0x8 > > +#define MVMDIO_XSMI_PHYADDR_SHIFT 16 > > +#define MVMDIO_XSMI_DEVADDR_SHIFT 21 > > +#define MVMDIO_XSMI_READ_OPERATION (0x7 << 26) > > +#define MVMDIO_XSMI_WRITE_OPERATION (0x5 << 27) > > These two operations seem odd. Generally ops have the same shift.
Indeed, this is odd. I'll have a look at this. Thanks, Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
