On Fri, Jun 09, 2017 at 06:22:16PM +0200, Antoine Tenart wrote: > On Fri, Jun 09, 2017 at 05:03:40PM +0200, Andrew Lunn wrote: > > > There are two busses, one generating c22 transactions and one generating > > > c45 transactions. Each bus has its own MDC/MDIO pins. > > > > O.K. That is what i wanted to know. So we want two completely separate > > device tree bindings, busses registered with Linux, etc. > > > > Thanks for clarification. > > So in the end I need one change in v3: to bind the xSMI usage to > marvell,xmdio and the SMI one to marvell,orion-mdio. (Plus the GENMASK > and offset comments).
Also, you need to 1. trap out on incorrect MII_ADDR_C45 in regnum for the interface. 2. mask the dev_addr with GENMASK(4, 0) (as merely shifting will leave the MII_ADDR_C45 bit set.) 3. moving MVMDIO_XSMI_PHYADDR_SHIFT / MVMDIO_XSMI_DEVADDR_SHIFT / MVMDIO_XSMI_READ_OPERATION / MVMDIO_XSMI_WRITE_OPERATION under the MVMDIO_XSMI_MGNT_REG reg - these definitions are nothing to do with MVMDIO_XSMI_ADDR_REG. 4. fixing MVMDIO_XSMI_WRITE_OPERATION to be 5 << 26, not 5 << 27. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.