On 06/13/2017 08:07 AM, Mason wrote:> I did note something that seems important. > > If I toggle the link state in software, then connectivity breaks. > > If I unplug the ethernet cable, and replug, connectivity remains.
What does that actually mean? If you disconnect the cable a link state should be notified and another link state should be notified, even if that happens faster than the PHYLIB polling time (1s). > > The difference is that plugging/unplugging doesn't call the > .ndo_stop callback. But 'ip link set eth0 down' does call it. > > Should the .ndo_stop callback be symmetric to the .ndo_open callback? Yes obviously. > In other words, should .ndo_open(); .ndo_stop(); be a NOP? -- Florian
